Page MenuHomePhabricator

Update chainparams
ClosedPublic

Authored by Fabien on Aug 29 2019, 13:48.

Details

Summary

Mainnet:

  • defaultAssumeValid set to block at height 597907.
  • nMinimumChainWork set to the work of block at 597909.

Skipping testnet update to avoid messing with the upgraded testnet.

Test Plan

Compare against you own nodes.
Check IBD (CI).

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

src/chainparams.cpp
279 ↗(On Diff #11022)

Please review carefully.
All the explorers seem to be down, so I have no comparison point.

Mengerian requested changes to this revision.Aug 29 2019, 16:42
Mengerian added a subscriber: Mengerian.

Chainwork is above the value on the Upgrade testnet, which will make it more complicated for people to run this release on the upgrade testnet.

Could we change that to keep it below that value?

src/chainparams.cpp
274 ↗(On Diff #11022)

Would it be possible to keep this value to 000000000000000000000000000000000000000000000051a4ba8069b54ed8f6 or lower?

this is the current chainwork for the upgrade testnet, and keeping below that would make it easier for people to run 0.20.1 binaries on the upgrade testnet.

This revision now requires changes to proceed.Aug 29 2019, 16:42
src/chainparams.cpp
279 ↗(On Diff #11022)

This looks fine, checked on my local node.

Fabien planned changes to this revision.Aug 29 2019, 17:15
Fabien edited the summary of this revision. (Show Details)

checked on my local node, looks good.

This revision is now accepted and ready to land.Aug 29 2019, 17:29
This revision was automatically updated to reflect the committed changes.