Page MenuHomePhabricator
Differential D3972

Update chainparams
ClosedPublic
Actions

Authored by Fabien on Aug 29 2019, 13:48.

Details

Reviewers
deadalnix
Mengerian
Group Reviewers
Restricted Project
Commits
rSTAGING8eb794b3be29: Update chainparams
rABC8eb794b3be29: Update chainparams
Summary

Mainnet:

  • defaultAssumeValid set to block at height 597907.
  • nMinimumChainWork set to the work of block at 597909.

Skipping testnet update to avoid messing with the upgraded testnet.

Test Plan

Compare against you own nodes.
Check IBD (CI).

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Aug 29 2019, 13:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 29 2019, 13:48
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Aug 29 2019, 13:48

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien added inline comments.Aug 29 2019, 13:49
src/chainparams.cpp
279 ↗(On Diff #11022)

Please review carefully.
All the explorers seem to be down, so I have no comparison point.

teamcity added a comment.Aug 29 2019, 13:55

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7279: Diff 11022.Aug 29 2019, 13:55
Fabien added a child revision: D3973: Update manpages for 0.20.1 release.Aug 29 2019, 13:57
Mengerian requested changes to this revision.Aug 29 2019, 16:42
Mengerian added a subscriber: Mengerian.

Chainwork is above the value on the Upgrade testnet, which will make it more complicated for people to run this release on the upgrade testnet.

Could we change that to keep it below that value?

src/chainparams.cpp
274 ↗(On Diff #11022)

Would it be possible to keep this value to 000000000000000000000000000000000000000000000051a4ba8069b54ed8f6 or lower?

this is the current chainwork for the upgrade testnet, and keeping below that would make it easier for people to run 0.20.1 binaries on the upgrade testnet.

This revision now requires changes to proceed.Aug 29 2019, 16:42
Mengerian added inline comments.Aug 29 2019, 16:44
src/chainparams.cpp
279 ↗(On Diff #11022)

This looks fine, checked on my local node.

Fabien planned changes to this revision.Aug 29 2019, 17:15
Fabien edited the summary of this revision. (Show Details)
Fabien updated this revision to Diff 11028.Aug 29 2019, 17:17

Skip testnet.

Mengerian accepted this revision.Aug 29 2019, 17:29

checked on my local node, looks good.

This revision is now accepted and ready to land.Aug 29 2019, 17:29
teamcity added a comment.Aug 29 2019, 17:44

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 29 2019, 17:46

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 29 2019, 17:53

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7282: Diff 11028.Aug 29 2019, 17:53
Mengerian mentioned this in D3973: Update manpages for 0.20.1 release.Aug 29 2019, 18:17
Closed by commit rABC8eb794b3be29: Update chainparams (authored by Fabien). · Explain WhyAug 29 2019, 18:48
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC8eb794b3be29: Update chainparams.
Fabien added a commit: rSTAGING8eb794b3be29: Update chainparams.Sep 19 2019, 02:05

Revision Contents
Changeset List

PathSize
src/
4 lines

Diff 11032

View Options

src/chainparams.cpp

Loading...