Page MenuHomePhabricator
Differential D397

pep8 mininode.py
ClosedPublic
Actions

Authored by deadalnix on Jul 31 2017, 10:58.

Details

Reviewers
freetrader
Group Reviewers
Restricted Project
Commits
rSTAGING71cb78f464d3: pep8 mininode.py
rABC71cb78f464d3: pep8 mininode.py
Summary

As per title.

Test Plan
../qa/pull-tester/rpc-tests.py -extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pep8mininode
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 617
Build 617: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 31 2017, 10:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 31 2017, 10:58
Harbormaster completed remote builds in B617: Diff 988.Jul 31 2017, 10:58
freetrader accepted this revision.Aug 2 2017, 21:23

Looks ok, though the code will need some post-processing love later on e.g. eliminate same-line comments, put some docstrings etc.

This revision is now accepted and ready to land.Aug 2 2017, 21:23
Closed by commit rABC71cb78f464d3: pep8 mininode.py (authored by deadalnix, committed by deadalnix). · Explain WhyAug 3 2017, 08:07
This revision was automatically updated to reflect the committed changes.
PiRK mentioned this in D8274: fix some style issues with comments.Nov 5 2020, 09:16
PiRK mentioned this in rABC1ade496abd8f: fix some style issues with comments.Nov 5 2020, 11:03

Revision Contents
Changeset List

PathSize
qa/
rpc-tests/
test_framework/
169 lines

Diff 988

View Options

qa/rpc-tests/test_framework/mininode.py

Loading...