Page MenuHomePhabricator

cli: Ignore libevent warnings
Needs RevisionPublic

Authored by fpelliccioni on Thu, Sep 5, 19:07.

Details

Reviewers
Fabien
deadalnix
Group Reviewers
Restricted Project
Summary

Should fix rpc tests that fail due to an unclean stderr.

Backport of Bitcoin Core PR13394
https://github.com/bitcoin/bitcoin/pull/13394

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
feature-backport-e1f8dce99
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7330
Build 12703: Bitcoin ABC Teamcity Staging
Build 12702: arc lint + arc unit

Event Timeline

fpelliccioni created this revision.Thu, Sep 5, 19:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Sep 5, 19:07
Fabien requested changes to this revision.Fri, Sep 6, 07:06

The code looks good but the test plan is unappropriated.
Can you check that the error occurs before the patch and no longer after ?

src/bitcoin-cli.cpp
113

Move comment above

This revision now requires changes to proceed.Fri, Sep 6, 07:06