Page MenuHomePhabricator

cli: Ignore libevent warnings
ClosedPublic

Authored by fpelliccioni on Sep 5 2019, 19:07.

Details

Summary

Should fix rpc tests that fail due to an unclean stderr.

Backport of Bitcoin Core PR13394
https://github.com/bitcoin/bitcoin/pull/13394

Test Plan

In a macOS terminal:

./src/bitcoind -regtest

In another macOS terminal:

./src/bitcoin-cli -regtest help

The following warning should not be seen in stdout/stderr:
[warn] kq_init: detected broken kqueue; not using.: Undefined error: 0

Diff Detail

Repository
rABC Bitcoin ABC
Branch
arcpatch-D4005
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7496
Build 13035: Bitcoin ABC Buildbot (legacy)
Build 13034: arc lint + arc unit

Event Timeline

Fabien requested changes to this revision.Sep 6 2019, 07:06

The code looks good but the test plan is unappropriated.
Can you check that the error occurs before the patch and no longer after ?

src/bitcoin-cli.cpp
113 ↗(On Diff #11104)

Move comment above

This revision now requires changes to proceed.Sep 6 2019, 07:06
fpelliccioni edited the test plan for this revision. (Show Details)
deadalnix requested changes to this revision.Sep 17 2019, 20:08
deadalnix added inline comments.
src/bitcoin-cli.cpp
114

Put the comment before the #define

This revision now requires changes to proceed.Sep 17 2019, 20:08
This revision is now accepted and ready to land.Sep 20 2019, 05:54
This revision was automatically updated to reflect the committed changes.