Page MenuHomePhabricator

[CMAKE] Move version to the top level CMakeLists.txt
ClosedPublic

Authored by Fabien on Sep 10 2019, 15:54.

Details

Summary

Apart from making it easier to figure out where it is located, it will
also avoid duplicating it when using CPack.

Depends on D4027.

Test Plan
ninja

Check the version is correct:

./src/bitcoind --version
./src/qt/bitcoin-qt --version
./src/bitcoin-cli --version
./src/bitcoin-tx -h

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Sep 10 2019, 15:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 10 2019, 15:54
jasonbcox requested changes to this revision.Sep 10 2019, 19:54
jasonbcox added a subscriber: jasonbcox.

release-process.md needs updating

This revision now requires changes to proceed.Sep 10 2019, 19:54
Fabien updated this revision to Diff 11185.Sep 11 2019, 06:27

Update the release process doc.

deadalnix accepted this revision.Sep 11 2019, 11:56
jasonbcox accepted this revision.Sep 11 2019, 16:46
This revision is now accepted and ready to land.Sep 11 2019, 16:46
This revision was automatically updated to reflect the committed changes.