Remove dependency on Config from the PoW code
ClosedPublic
Actions

Authored by deadalnix on Sep 11 2019, 09:24.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGfd79071ecb95: Remove dependency on Config from the PoW code
rABCfd79071ecb95: Remove dependency on Config from the PoW code

Summary

As per title.

Depends on D4030

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

consensuscheckpow

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7383
Build 12809: Bitcoin ABC Buildbot (legacy)
Build 12808: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 11 2019, 09:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 11 2019, 09:24

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7383: Diff 11188.Sep 11 2019, 09:33

deadalnix added a child revision: D4033: Remove ReadBlockFromDisk's dependency on Config.Sep 11 2019, 12:02

deadalnix added a child revision: D4034: Modify ContextualCheckBlockHeader to accept a CChainParam rather than a Config.Sep 11 2019, 12:25

Fabien accepted this revision.Sep 11 2019, 14:39

This revision is now accepted and ready to land.Sep 11 2019, 14:39

Closed by commit rABCfd79071ecb95: Remove dependency on Config from the PoW code (authored by deadalnix). · Explain WhySep 11 2019, 15:39

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCfd79071ecb95: Remove dependency on Config from the PoW code.

deadalnix added a commit: rSTAGINGfd79071ecb95: Remove dependency on Config from the PoW code.Sep 19 2019, 02:14

Revision Contents
Changeset List

Path

Size

src/

6 lines

14 lines

15 lines

35 lines

rpc/

mining.cpp

5 lines

test/

blockencodings_tests.cpp

6 lines

pow_tests.cpp

50 lines

test_bitcoin.cpp

3 lines

validation_block_tests.cpp

9 lines

txdb.h

7 lines

txdb.cpp

4 lines

validation.cpp

16 lines

Diff 11188

View Options

src/miner.h

View Options

src/miner.cpp

View Options

src/pow.h

View Options

src/pow.cpp

View Options

src/rpc/mining.cpp

View Options

src/test/blockencodings_tests.cpp

View Options

src/test/pow_tests.cpp

View Options

src/test/test_bitcoin.cpp

View Options

src/test/validation_block_tests.cpp

View Options

src/txdb.h

View Options

src/txdb.cpp

View Options

Remove dependency on Config from the PoW codeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 11188

src/miner.h

src/miner.cpp

src/pow.h

src/pow.cpp

src/rpc/mining.cpp

src/test/blockencodings_tests.cpp

src/test/pow_tests.cpp

src/test/test_bitcoin.cpp

src/test/validation_block_tests.cpp

src/txdb.h

src/txdb.cpp

src/validation.cpp

Remove dependency on Config from the PoW code
ClosedPublic
Actions

Revision Contents
Changeset List