Page MenuHomePhabricator

[CMAKE] Fix Linux64 toolchain name
ClosedPublic

Authored by Fabien on Wed, Sep 11, 15:15.

Details

Summary

The toolchain is named with an extra -pc in its name (just like the 32
bits version) but it should not.
Using this mistaken name as the depends name will still work when the
host is a 64 bits linux as it will default to the good system.

Test Plan
cd depends
make build-linux64
mkdir ../buildcmake && cd ../buildcmake
cmake -GNinja .. \
-DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Linux64.cmake
ninja

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Wed, Sep 11, 15:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Sep 11, 15:15
deadalnix requested changes to this revision.Wed, Sep 11, 16:02

The test plan is not appropriate.

This revision now requires changes to proceed.Wed, Sep 11, 16:02
Fabien requested review of this revision.Wed, Sep 11, 16:33
Fabien edited the test plan for this revision. (Show Details)
Fabien edited the test plan for this revision. (Show Details)

Fixed a typo in the test plan and improved the instructions

deadalnix accepted this revision.Thu, Sep 12, 07:17
This revision is now accepted and ready to land.Thu, Sep 12, 07:17
This revision was automatically updated to reflect the committed changes.