Page MenuHomePhabricator
Differential D4038

[CMAKE] Fix Linux64 toolchain name
ClosedPublic
Actions

Authored by Fabien on Sep 11 2019, 15:15.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING43f64b728bb5: [CMAKE] Fix Linux64 toolchain name
rABC43f64b728bb5: [CMAKE] Fix Linux64 toolchain name
Summary

The toolchain is named with an extra -pc in its name (just like the 32
bits version) but it should not.
Using this mistaken name as the depends name will still work when the
host is a 64 bits linux as it will default to the good system.

Test Plan
cd depends
make build-linux64
mkdir ../buildcmake && cd ../buildcmake
cmake -GNinja .. \
-DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Linux64.cmake
ninja

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_linux64_typo
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7389
Build 12821: Bitcoin ABC Buildbot (legacy)
Build 12820: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 11 2019, 15:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 11 2019, 15:15
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Sep 11 2019, 15:15

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien added a child revision: D4039: [CMAKE] Fix linux cross compilation with the glibc compatibility.Sep 11 2019, 15:19
teamcity added a comment.Sep 11 2019, 15:22

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7389: Diff 11198.Sep 11 2019, 15:22
deadalnix requested changes to this revision.Sep 11 2019, 16:02

The test plan is not appropriate.

This revision now requires changes to proceed.Sep 11 2019, 16:02
Fabien requested review of this revision.Sep 11 2019, 16:33
Fabien edited the test plan for this revision. (Show Details)
Fabien edited the test plan for this revision. (Show Details)

Fixed a typo in the test plan and improved the instructions

deadalnix accepted this revision.Sep 12 2019, 07:17
This revision is now accepted and ready to land.Sep 12 2019, 07:17
Closed by commit rABC43f64b728bb5: [CMAKE] Fix Linux64 toolchain name (authored by Fabien). · Explain WhySep 12 2019, 08:26
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC43f64b728bb5: [CMAKE] Fix Linux64 toolchain name.
Fabien added a commit: rSTAGING43f64b728bb5: [CMAKE] Fix Linux64 toolchain name.Sep 19 2019, 02:16

Revision Contents
Changeset List

PathSize
cmake/
platforms/
2 lines

Diff 11198

View Options

cmake/platforms/Linux64.cmake

Loading...