Page MenuHomePhabricator

[SECP256K1] Create a different library when building with JNI
ClosedPublic

Authored by Fabien on Sep 12 2019, 16:42.

Details

Summary

The current behavior is to build a secp256k1 library that has the JNI
binding feature if enabled.
This diff keeps the main secp256k1 library intact, and creates another
secp256k1_jni library with JNI support in it. The java test is updated
to reflect this.

Depends on D4053.

Test Plan
cd secp256k1
./autogen.sh
mkdir build && cd build
../configure --enable-jni --enable-experimental --enable-module-ecdh
make

Check there is a libsecp256k1_jni.so file under .libs/

make check-java

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Sep 12 2019, 16:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 12 2019, 16:42
deadalnix requested changes to this revision.Sep 13 2019, 08:10
deadalnix added inline comments.
src/secp256k1/Makefile.am
9 ↗(On Diff #11254)

It doesn't look like this is necessary anymore.

This revision now requires changes to proceed.Sep 13 2019, 08:10
Fabien updated this revision to Diff 11315.Sep 14 2019, 16:00

Cleanup the obsolete variable.

deadalnix accepted this revision.Sep 14 2019, 17:07
This revision is now accepted and ready to land.Sep 14 2019, 17:07