Page MenuHomePhabricator

[SECP256K1] Build java class files out of tree
ClosedPublic

Authored by Fabien on Sep 12 2019, 15:55.

Details

Summary

The Java files are compiled to the source tree, making it difficult to
restart a build. Fix this by passing the output directory to javac.

Test Plan
cd secp256k1
./autogen.sh
mkdir build && cd build
../configure --enable-jni --enable-experimental --enable-module-ecdh
make check-java

Check the .class files are located under the build directory
(build/src/java/org/bitcoin/*.class).

make clean

Check the .class files are deleted.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Better variable factorization.

This revision is now accepted and ready to land.Sep 13 2019, 06:11