Page MenuHomePhabricator
Differential D4053

[SECP256K1] Build java class files out of tree
ClosedPublic
Actions

Authored by Fabien on Sep 12 2019, 15:55.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGa3cf7aae0c75: [SECP256K1] Build java class files out of tree
rABCa3cf7aae0c75: [SECP256K1] Build java class files out of tree
Summary

The Java files are compiled to the source tree, making it difficult to
restart a build. Fix this by passing the output directory to javac.

Test Plan
cd secp256k1
./autogen.sh
mkdir build && cd build
../configure --enable-jni --enable-experimental --enable-module-ecdh
make check-java

Check the .class files are located under the build directory
(build/src/java/org/bitcoin/*.class).

make clean

Check the .class files are deleted.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
secp256k1_java_out_of_tree
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7428
Build 12899: Bitcoin ABC Buildbot (legacy)
Build 12898: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 12 2019, 15:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 12 2019, 15:55
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Sep 12 2019, 15:55

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 12 2019, 16:02

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7422: Diff 11245.Sep 12 2019, 16:02
Fabien updated this revision to Diff 11253.Sep 12 2019, 16:36

Better variable factorization.

teamcity added a comment.Sep 12 2019, 16:39

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien added a child revision: D4058: [SECP256K1] Create a different library when building with JNI.Sep 12 2019, 16:42
teamcity added a comment.Sep 12 2019, 16:49

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7428: Diff 11253.Sep 12 2019, 16:49
deadalnix accepted this revision.Sep 13 2019, 06:11
This revision is now accepted and ready to land.Sep 13 2019, 06:11
Closed by commit rABCa3cf7aae0c75: [SECP256K1] Build java class files out of tree (authored by Fabien). · Explain WhySep 14 2019, 15:55
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCa3cf7aae0c75: [SECP256K1] Build java class files out of tree.
Fabien added a commit: rSTAGINGa3cf7aae0c75: [SECP256K1] Build java class files out of tree.Sep 19 2019, 02:21

Revision Contents
Changeset List

PathSize
src/
secp256k1/
21 lines

Diff 11253

View Options

src/secp256k1/Makefile.am

Loading...