[CI] Fix missing parameters transfer from ibd.sh to bitcoind
ClosedPublic
Actions

Authored by jasonbcox on Sep 12 2019, 20:42.

Details

Reviewers

deadalnix
Fabien
nakihito

Group Reviewers

Restricted Project

Commits

rSTAGINGc59eff33b799: [CI] Fix missing parameters transfer from ibd.sh to bitcoind
rABCc59eff33b799: [CI] Fix missing parameters transfer from ibd.sh to bitcoind

Summary

The ibd.sh script is expected to transfer its arguments to bitcoind.
This allow to set the assumevalid and checkpoints options as needed.

Test Plan

./contrib/teamcity/ibd.sh -assumevalid=0 -checkpoints=0

Check in the output that bitcoind is started with these arguments.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Sep 12 2019, 20:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 12 2019, 20:42

Herald added a reviewer: deadalnix. · View Herald Transcript

jasonbcox accepted this revision.Sep 12 2019, 20:44

This revision is now accepted and ready to land.Sep 12 2019, 20:44

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7435: Diff 11266.Sep 12 2019, 20:55

jasonbcox commandeered this revision.Sep 13 2019, 00:37

jasonbcox edited reviewers, added: Fabien; removed: jasonbcox.

This revision now requires review to proceed.Sep 13 2019, 00:37

nakihito accepted this revision.Sep 13 2019, 00:38

This revision is now accepted and ready to land.Sep 13 2019, 00:38

Closed by commit rABCc59eff33b799: [CI] Fix missing parameters transfer from ibd.sh to bitcoind (authored by Fabien, committed by jasonbcox). · Explain WhySep 13 2019, 01:11

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABCc59eff33b799: [CI] Fix missing parameters transfer from ibd.sh to bitcoind.

jasonbcox added a commit: rSTAGINGc59eff33b799: [CI] Fix missing parameters transfer from ibd.sh to bitcoind.Sep 19 2019, 02:18

Revision Contents
Changeset List

Path

Size

contrib/

teamcity/

ibd.sh

2 lines

Diff 11279

View Options

[CI] Fix missing parameters transfer from ibd.sh to bitcoindClosedPublicActions