Page MenuHomePhabricator
Differential D4062

Adding test case for SINGLE|ANYONECANPAY hash type in tx_valid.json
ClosedPublic
Actions

Authored by fpelliccioni on Sep 12 2019, 20:52.

Details

Reviewers
Fabien
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING74a94f46047a: Adding test case for SINGLE|ANYONECANPAY hash type in tx_valid.json
rABC74a94f46047a: Adding test case for SINGLE|ANYONECANPAY hash type in tx_valid.json
Summary

We are missing a test vector for SINGLE|ANYONECANPAY inside of tx_valid.json. This addresses the issue #12060

Backport of Bitcoin Core PR12082
https://github.com/bitcoin/bitcoin/pull/12082

Test Plan
make check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

fpelliccioni created this revision.Sep 12 2019, 20:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 12 2019, 20:52
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Sep 12 2019, 20:52

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 12 2019, 21:00

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7436: Diff 11268.Sep 12 2019, 21:00
deadalnix added a comment.Sep 13 2019, 08:16

check-all is unnecessary in that case. If you use cmake, I strongly advise you use ninja instead of make and it is way faster.

deadalnix accepted this revision.Sep 13 2019, 08:18
This revision is now accepted and ready to land.Sep 13 2019, 08:18
fpelliccioni added a comment.Sep 13 2019, 17:19
In D4062#95545, @deadalnix wrote:

check-all is unnecessary in that case. If you use cmake, I strongly advise you use ninja instead of make and it is way faster.

Thanks for the advice!

Closed by commit rABC74a94f46047a: Adding test case for SINGLE|ANYONECANPAY hash type in tx_valid.json (authored by Chris Stewart <stewart.chris1234@gmail.com>, committed by fpelliccioni). · Explain WhySep 13 2019, 17:36
This revision was automatically updated to reflect the committed changes.
fpelliccioni added a commit: rABC74a94f46047a: Adding test case for SINGLE|ANYONECANPAY hash type in tx_valid.json.
fpelliccioni added a commit: rSTAGING74a94f46047a: Adding test case for SINGLE|ANYONECANPAY hash type in tx_valid.json.Sep 19 2019, 02:19

Revision Contents
Changeset List

PathSize
src/
test/
data/
6 lines

Diff 11290

View Options

src/test/data/tx_valid.json

Loading...