tests: remove member connman/peerLogic in TestingSetup
ClosedPublic
Actions

Authored by deadalnix on Sep 13 2019, 11:13.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING70b9a1207e4e: tests: remove member connman/peerLogic in TestingSetup
rABC70b9a1207e4e: tests: remove member connman/peerLogic in TestingSetup

Summary

This is a partial backport of Core PR14605 : https://github.com/bitcoin/bitcoin/pull/14605/commits/136bd7926c72659dd277a7b795ea17f72e523338

This required to have various tests modified as they use std::unique_ptr.

Depends on D4069

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Sep 13 2019, 11:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 13 2019, 11:13

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7446: Diff 11287.Sep 13 2019, 11:25

Fabien accepted this revision.Sep 14 2019, 17:07

This revision is now accepted and ready to land.Sep 14 2019, 17:07

Closed by commit rABC70b9a1207e4e: tests: remove member connman/peerLogic in TestingSetup (authored by Cory Fields <cory-nospam-@coryfields.com>, committed by deadalnix). · Explain WhySep 14 2019, 17:25

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC70b9a1207e4e: tests: remove member connman/peerLogic in TestingSetup.

deadalnix added a commit: rSTAGING70b9a1207e4e: tests: remove member connman/peerLogic in TestingSetup.Sep 19 2019, 02:22

Revision Contents
Changeset List

Path

Size

src/

test/

avalanche_tests.cpp

161 lines

denialofservice_tests.cpp

57 lines

test_bitcoin.h

6 lines

test_bitcoin.cpp

17 lines

Diff 11324

View Options

src/test/avalanche_tests.cpp

View Options

src/test/denialofservice_tests.cpp

View Options

src/test/test_bitcoin.h

View Options

tests: remove member connman/peerLogic in TestingSetupClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 11324

src/test/avalanche_tests.cpp

src/test/denialofservice_tests.cpp

src/test/test_bitcoin.h

src/test/test_bitcoin.cpp

tests: remove member connman/peerLogic in TestingSetup
ClosedPublic
Actions

Revision Contents
Changeset List