Page MenuHomePhabricator

[qt] Replaces numbered place marker %2 with %1.
ClosedPublic

Authored by fpelliccioni on Sep 13 2019, 22:28.

Details

Summary

This PR closes #12015 in which @chen610620 suggests to replace numbered place marker %2 with %1.

Backport of Bitcoin Core PR12092
https://github.com/bitcoin/bitcoin/pull/12092

Test Plan
make
./src/qt/bitcoin-qt -regtest
  1. Open the "Send" dialog.
  2. Enter a BCH testnet address.
  3. Enter a valid amount.
  4. Press "Send" button, at bottom.
  5. Check that the confirmation message is Ok.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

fpelliccioni created this revision.Sep 13 2019, 22:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 13 2019, 22:28
deadalnix requested changes to this revision.Sat, Sep 14, 07:55

Test plan

This revision now requires changes to proceed.Sat, Sep 14, 07:55
fpelliccioni edited the test plan for this revision. (Show Details)Tue, Sep 17, 16:11
fpelliccioni updated this revision to Diff 11366.Tue, Sep 17, 16:14
fpelliccioni edited the test plan for this revision. (Show Details)

test plan updated.

deadalnix accepted this revision.Tue, Sep 17, 17:56
This revision is now accepted and ready to land.Tue, Sep 17, 17:56
This revision was automatically updated to reflect the committed changes.