Page MenuHomePhabricator

[qt] Replaces numbered place marker %2 with %1.
ClosedPublic

Authored by fpelliccioni on Sep 13 2019, 22:28.

Details

Summary

This PR closes #12015 in which @chen610620 suggests to replace numbered place marker %2 with %1.

Backport of Bitcoin Core PR12092
https://github.com/bitcoin/bitcoin/pull/12092

Test Plan
make
./src/qt/bitcoin-qt -regtest
  1. Open the "Send" dialog.
  2. Enter a BCH testnet address.
  3. Enter a valid amount.
  4. Press "Send" button, at bottom.
  5. Check that the confirmation message is Ok.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
feature-backport-fd4ca1736
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7453
Build 12949: Bitcoin ABC Buildbot (legacy)
Build 12948: arc lint + arc unit

Event Timeline

This revision now requires changes to proceed.Sep 14 2019, 07:55
fpelliccioni edited the test plan for this revision. (Show Details)

test plan updated.

This revision is now accepted and ready to land.Sep 17 2019, 17:56