Page MenuHomePhabricator

[qt] send: Clear All also resets coin control options
ClosedPublic

Authored by fpelliccioni on Sep 13 2019, 22:28.

Details

Summary

This change makes it so that a custom change address and manual input selection are removed if the user clicks Clear All in the send screen.

Backport of Bitcoin Core PR12432
https://github.com/bitcoin/bitcoin/pull/12432

Test Plan
  1. Start BitcoinABC wallet: ./src/qt/bitcoin-qt -regtest
  2. Enable the check named Enable coin control features, at Settings -> Options -> Wallet.
  3. Go to Send dialog.
  4. Enable the check Custom change address and fill with one address at the right.
  5. Click on Clear all button.
  6. Verify that the checkbox and the Custom change address text are cleaned.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

fpelliccioni created this revision.Sep 13 2019, 22:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 13 2019, 22:28
deadalnix requested changes to this revision.Sep 14 2019, 07:53

The test plan is not appropriate.

This revision now requires changes to proceed.Sep 14 2019, 07:53
fpelliccioni edited the test plan for this revision. (Show Details)Sep 18 2019, 17:52
fpelliccioni updated this revision to Diff 11383.Sep 18 2019, 17:53
fpelliccioni edited the test plan for this revision. (Show Details)

Test plan updated.

deadalnix accepted this revision.Sep 19 2019, 11:57
This revision is now accepted and ready to land.Sep 19 2019, 11:57