Page MenuHomePhabricator
Differential D4078

[qt] send: Clear All also resets coin control options
ClosedPublic
Actions

Authored by fpelliccioni on Sep 13 2019, 22:28.

Details

Reviewers
Fabien
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING2ec61ddea958: [qt] send: Clear All also resets coin control options
rABC2ec61ddea958: [qt] send: Clear All also resets coin control options
Summary

This change makes it so that a custom change address and manual input selection are removed if the user clicks Clear All in the send screen.

Backport of Bitcoin Core PR12432
https://github.com/bitcoin/bitcoin/pull/12432

Test Plan
  1. Start BitcoinABC wallet: ./src/qt/bitcoin-qt -regtest
  2. Enable the check named Enable coin control features, at Settings -> Options -> Wallet.
  3. Go to Send dialog.
  4. Enable the check Custom change address and fill with one address at the right.
  5. Click on Clear all button.
  6. Verify that the checkbox and the Custom change address text are cleaned.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
feature-backport-9fb3898c3
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7501
Build 13045: Bitcoin ABC Buildbot (legacy)
Build 13044: arc lint + arc unit

Event Timeline

fpelliccioni created this revision.Sep 13 2019, 22:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 13 2019, 22:28
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Sep 13 2019, 22:28

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 13 2019, 22:38

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7454: Diff 11304.Sep 13 2019, 22:38
deadalnix requested changes to this revision.Sep 14 2019, 07:53

The test plan is not appropriate.

This revision now requires changes to proceed.Sep 14 2019, 07:53
fpelliccioni edited the test plan for this revision. (Show Details)Sep 18 2019, 17:52
fpelliccioni updated this revision to Diff 11383.Sep 18 2019, 17:53
fpelliccioni edited the test plan for this revision. (Show Details)

Test plan updated.

teamcity added a comment.Sep 18 2019, 17:53

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 18 2019, 18:08

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7501: Diff 11383.Sep 18 2019, 18:08
deadalnix accepted this revision.Sep 19 2019, 11:57
This revision is now accepted and ready to land.Sep 19 2019, 11:57
Closed by commit rABC2ec61ddea958: [qt] send: Clear All also resets coin control options (authored by fpelliccioni). · Explain WhySep 20 2019, 12:37
This revision was automatically updated to reflect the committed changes.
fpelliccioni added a commit: rABC2ec61ddea958: [qt] send: Clear All also resets coin control options.
fpelliccioni added a commit: rSTAGING2ec61ddea958: [qt] send: Clear All also resets coin control options.Sep 27 2019, 22:45

Revision Contents
Changeset List

PathSize
src/
qt/
6 lines

Diff 11383

View Options

src/qt/sendcoinsdialog.cpp

Loading...