Page MenuHomePhabricator
Differential D4082

Prefer wait_until over polling with time.sleep
ClosedPublic
Actions

Authored by deadalnix on Sep 14 2019, 13:56.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING16854d62f596: Prefer wait_until over polling with time.sleep
rABC16854d62f596: Prefer wait_until over polling with time.sleep
Summary
  • test: Use wait_until in tests where time was used for polling
  • test: Use os.path.join consistently in feature_pruning tests

This is a backport of Core PR12553

Test Plan
make check
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Sep 14 2019, 13:56
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 14 2019, 13:56
teamcity added a comment.Sep 14 2019, 13:57

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 14 2019, 14:04

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7459: Diff 11310.Sep 14 2019, 14:04
deadalnix added a child revision: D4083: Report minfeefilter value in getpeerinfo rpc.Sep 14 2019, 14:28
Fabien requested changes to this revision.Sep 14 2019, 16:13
Fabien added a subscriber: Fabien.

You can improve the summary to make it understandable why it doesn't match the title.
Also make check is of no help here.

test/functional/wallet_basic.py
418 ↗(On Diff #11310)

Revert all 3

This revision now requires changes to proceed.Sep 14 2019, 16:13
deadalnix retitled this revision from test: Use wait_until in tests where time was used for polling to Prefer wait_until over polling with time.sleep.Sep 14 2019, 16:22
deadalnix edited the summary of this revision. (Show Details)
deadalnix updated this revision to Diff 11316.Sep 14 2019, 16:23

spaces around plus

teamcity added a comment.Sep 14 2019, 16:23

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 14 2019, 16:30

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7464: Diff 11316.Sep 14 2019, 16:30
Fabien accepted this revision.Sep 14 2019, 16:33
This revision is now accepted and ready to land.Sep 14 2019, 16:33
Closed by commit rABC16854d62f596: Prefer wait_until over polling with time.sleep (authored by Ben Woosley <ben.woosley@gmail.com>, committed by deadalnix). · Explain WhySep 14 2019, 16:35
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC16854d62f596: Prefer wait_until over polling with time.sleep.
deadalnix added a commit: rSTAGING16854d62f596: Prefer wait_until over polling with time.sleep.Sep 19 2019, 02:21

Revision Contents
Changeset List

PathSize
test/
functional/
25 lines
8 lines
11 lines
test_framework/
13 lines
6 lines

Diff 11317

View Options

test/functional/feature_pruning.py

Loading...
View Options

test/functional/feature_reindex.py

Loading...
View Options

test/functional/rpc_net.py

Loading...
View Options

test/functional/test_framework/util.py

Loading...
View Options

test/functional/wallet_basic.py

Loading...