Page MenuHomePhabricator

Prefer wait_until over polling with time.sleep
ClosedPublic

Authored by deadalnix on Sep 14 2019, 13:56.

Details

Summary
  • test: Use wait_until in tests where time was used for polling
  • test: Use os.path.join consistently in feature_pruning tests

This is a backport of Core PR12553

Test Plan
make check
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr12553
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7459
Build 12961: Bitcoin ABC Buildbot (legacy)
Build 12960: arc lint + arc unit

Event Timeline

Fabien requested changes to this revision.Sep 14 2019, 16:13
Fabien added a subscriber: Fabien.

You can improve the summary to make it understandable why it doesn't match the title.
Also make check is of no help here.

test/functional/wallet_basic.py
418

Revert all 3

This revision now requires changes to proceed.Sep 14 2019, 16:13
deadalnix retitled this revision from test: Use wait_until in tests where time was used for polling to Prefer wait_until over polling with time.sleep.Sep 14 2019, 16:22
deadalnix edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Sep 14 2019, 16:33