Page MenuHomePhabricator

net: Add Clang thread safety annotations for guarded variables in the networking code
ClosedPublic

Authored by deadalnix on Sep 14 2019, 14:53.

Details

Summary
  • Add missing lock in CNode::copyStats(...)
  • Add missing locking annotations

This is a backport of Core PR13123

Depends on D4083

Test Plan
cmake -GNinja -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ ..
ninja

Check that there are no thread safety analysis warnings.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable