Page MenuHomePhabricator

Move SocketHandler logic to private method.
ClosedPublic

Authored by deadalnix on Sep 15 2019, 19:12.

Details

Summary
Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr14335-4
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7472
Build 12987: Bitcoin ABC Buildbot (legacy)
Build 12986: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 15 2019, 19:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 15 2019, 19:12
Fabien requested changes to this revision.Sep 16 2019, 08:13
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/net.cpp
1347

Revert the comment

1380

Fix the comments layout.

1418

Braces

1424

Braces

1445

Braces

1449

Braces

1469

Revert to int32_t

1480

Braces

1487

Braces

1513

Braces

1536

Braces

This revision now requires changes to proceed.Sep 16 2019, 08:13
deadalnix updated this revision to Diff 11334.Sep 16 2019, 08:38

Fix braces and various othe small changes

Fabien accepted this revision.Sep 16 2019, 08:59
Fabien added inline comments.
src/net.cpp
1347 ↗(On Diff #11334)

NIt: restore capitalization.

This revision is now accepted and ready to land.Sep 16 2019, 08:59