Drop unused pindexRet arg to CMerkleTx::GetDepthInMainChain
ClosedPublic
Actions

Authored by deadalnix on Sep 16 2019, 15:20.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING26c617190d1b: Drop unused pindexRet arg to CMerkleTx::GetDepthInMainChain
rABC26c617190d1b: Drop unused pindexRet arg to CMerkleTx::GetDepthInMainChain

Summary

This is a backport of Core PR13630

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr13630

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7482
Build 13007: Bitcoin ABC Buildbot (legacy)
Build 13006: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 16 2019, 15:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 16 2019, 15:20

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7482: Diff 11348.Sep 16 2019, 15:29

deadalnix mentioned this in D4094: Add compile time checking for all cs_main runtime locking assertions.Sep 16 2019, 15:36

Fabien accepted this revision.Sep 17 2019, 06:08

This revision is now accepted and ready to land.Sep 17 2019, 06:08

Closed by commit rABC26c617190d1b: Drop unused pindexRet arg to CMerkleTx::GetDepthInMainChain (authored by Ben Woosley <ben.woosley@gmail.com>, committed by deadalnix). · Explain WhySep 17 2019, 09:09

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC26c617190d1b: Drop unused pindexRet arg to CMerkleTx::GetDepthInMainChain.

deadalnix added a commit: rSTAGING26c617190d1b: Drop unused pindexRet arg to CMerkleTx::GetDepthInMainChain.Sep 19 2019, 02:24

Revision Contents
Changeset List

Path

Size

src/

wallet/

wallet.h

11 lines

wallet.cpp

3 lines

Diff 11348

View Options

src/wallet/wallet.h