Page MenuHomePhabricator

Merge #13201: [qa] Handle disconnect_node race
ClosedPublic

Authored by nakihito on Sep 20 2019, 20:33.

Details

Summary

09c6699900 [qa] Handle disconnect_node race (Suhas Daftuar)

Pull request description:

Several tests call disconnect_nodes() on each node-pair in rapid
succession, resulting in a race condition if a node disconnects a peer
in-between the calculation of the nodeid's to disconnect and the
invocation of the disconnectnode rpc call.  Handle this.

Tree-SHA512: 3078cea0006fcb507c812004a777c505eb1e9dda7c6df12dbbe72395a73ff6f6760f597b6492054f5487b34534417ddef5fbad30553c135c288c4b7cfce79223

Backport of Core PR13201
https://github.com/bitcoin/bitcoin/pull/13201/

Test Plan
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a reviewer: Restricted Owners Package.Sep 20 2019, 20:33
This revision is now accepted and ready to land.Sep 23 2019, 21:51