Page MenuHomePhabricator
Differential D4143

[CMAKE] Migrate the python header generation scripts to python 3
ClosedPublic
Actions

Authored by Fabien on Sep 24 2019, 09:04.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING46261be23880: [CMAKE] Migrate the python header generation scripts to python 3
rABC46261be23880: [CMAKE] Migrate the python header generation scripts to python 3
Summary

The shebang has already been updated, but the scripts would fail with
python3. The read() function now returns a byte array when the file is
opened in binary mode, so the ord() is no longer needed.

The CMakeLists.txt files are updated to use the correct interpreter.

Test Plan
ninja check
ninja bitcoin-bench

Diff Detail

Repository
rABC Bitcoin ABC
Branch
migrate_header_generators_to_python3
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7564
Build 13168: Bitcoin ABC Buildbot (legacy)
Build 13167: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
bench/
2 lines
data/
2 lines
test/
2 lines
data/
2 lines

Diff 13104

View Options

src/bench/CMakeLists.txt

Loading...
View Options

src/bench/data/convert-raw-to-header.py

Loading...
View Options

src/test/CMakeLists.txt

Loading...
View Options

src/test/data/generate_header.py

Loading...