[CMAKE] Consistently find and use the python interpreter
ClosedPublic
Actions

Authored by Fabien on Sep 24 2019, 09:16.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGINGe36935e09971: [CMAKE] Consistently find and use the python interpreter
rABCe36935e09971: [CMAKE] Consistently find and use the python interpreter

Summary

Some of the python scripts rely on the shebang, some of them search for
the python program, the behavior is inconsistent across the files.

This diff makes use of find_package to get the python interpreter
executable path. This allow for failing with a meaningful error message
if python is not found or does not match the minimum version.

Depends on D4143.

Test Plan

mkdir buildcmake && cd buildcmake
cmake -GNinja ..
ninja check
ninja check-functional
ninja bench-bitcoin

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Sep 24 2019, 09:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 24 2019, 09:16

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7565: Diff 13105.Sep 24 2019, 09:26

Fabien planned changes to this revision.Sep 24 2019, 09:29

Fabien retitled this revision from [CMAKE] Consistently find the python interpreter to [CMAKE] Consistently find and use the python interpreter.Sep 24 2019, 09:34

Fabien edited the summary of this revision. (Show Details)

Search python once.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B7566: Diff 13106!Sep 24 2019, 09:39

Fabien mentioned this in D4136: [CMAKE] Add the check-symbols target.Sep 24 2019, 09:52

Build Bitcoin-ABC / Diffs / Diff Testing started.