Page MenuHomePhabricator

[CMAKE] Consistently find and use the python interpreter
ClosedPublic

Authored by Fabien on Sep 24 2019, 09:16.

Details

Summary

Some of the python scripts rely on the shebang, some of them search for
the python program, the behavior is inconsistent across the files.

This diff makes use of find_package to get the python interpreter
executable path. This allow for failing with a meaningful error message
if python is not found or does not match the minimum version.

Depends on D4143.

Test Plan
mkdir buildcmake && cd buildcmake
cmake -GNinja ..
ninja check
ninja check-functional
ninja bench-bitcoin

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_find_python
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7565
Build 13170: Bitcoin ABC Buildbot (legacy)
Build 13169: arc lint + arc unit

Event Timeline

Fabien planned changes to this revision.Sep 24 2019, 09:29
Fabien retitled this revision from [CMAKE] Consistently find the python interpreter to [CMAKE] Consistently find and use the python interpreter.Sep 24 2019, 09:34
Fabien edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Sep 24 2019, 14:07