Page MenuHomePhabricator

[CMAKE] Add the check-symbols target

Authored by Fabien on Sep 23 2019, 11:48.



This target runs the scripts on the executables.
This is the equivalent of the autotools check-symbols rule.

Test Plan

Build the depends subsystem for linux 64, then:

mkdir buildcmake && cd buildcmake
cmake -GNinja .. \
ninja check-symbols

If should be successful.

Diff Detail

rABC Bitcoin ABC
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Sep 23 2019, 11:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 23 2019, 11:48
jasonbcox accepted this revision.Sep 23 2019, 23:55
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
33 ↗(On Diff #13083)

Nit: This comment is looking redundant. Consider removing it.

This revision is now accepted and ready to land.Sep 23 2019, 23:55
Fabien planned changes to this revision.Sep 24 2019, 08:26
Fabien updated this revision to Diff 13107.Sep 24 2019, 09:51

Rebase on top of D4144.
Update comment as per feedback.
Do not check bench or test binaries, that are not intended to be installed.

This revision is now accepted and ready to land.Sep 24 2019, 09:51
This revision was automatically updated to reflect the committed changes.