Page MenuHomePhabricator

[CMAKE] Add the check-symbols target
ClosedPublic

Authored by Fabien on Mon, Sep 23, 11:48.

Details

Summary

This target runs the symbol-check.py scripts on the executables.
This is the equivalent of the autotools check-symbols rule.

Test Plan

Build the depends subsystem for linux 64, then:

mkdir buildcmake && cd buildcmake
cmake -GNinja .. \
  -DENABLE_GLIBC_BACK_COMPAT=ON \
  -DENABLE_STATIC_LIBSTDCXX=ON \
  -DENABLE_REDUCE_EXPORTS=ON \
  -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Linux64.cmake
ninja check-symbols

If should be successful.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Mon, Sep 23, 11:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Sep 23, 11:48
jasonbcox accepted this revision.Mon, Sep 23, 23:55
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
CMakeLists.txt
33 ↗(On Diff #13083)

Nit: This comment is looking redundant. Consider removing it.

This revision is now accepted and ready to land.Mon, Sep 23, 23:55
Fabien planned changes to this revision.Tue, Sep 24, 08:26
Fabien updated this revision to Diff 13107.Tue, Sep 24, 09:51

Rebase on top of D4144.
Update comment as per feedback.
Do not check bench or test binaries, that are not intended to be installed.

This revision is now accepted and ready to land.Tue, Sep 24, 09:51
This revision was automatically updated to reflect the committed changes.