Page MenuHomePhabricator

[CMAKE] Add the check-symbols target
ClosedPublic

Authored by Fabien on Sep 23 2019, 11:48.

Details

Summary

This target runs the symbol-check.py scripts on the executables.
This is the equivalent of the autotools check-symbols rule.

Test Plan

Build the depends subsystem for linux 64, then:

mkdir buildcmake && cd buildcmake
cmake -GNinja .. \
  -DENABLE_GLIBC_BACK_COMPAT=ON \
  -DENABLE_STATIC_LIBSTDCXX=ON \
  -DENABLE_REDUCE_EXPORTS=ON \
  -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Linux64.cmake
ninja check-symbols

If should be successful.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_check_symbols
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7567
Build 13174: Bitcoin ABC Buildbot (legacy)
Build 13173: arc lint + arc unit

Event Timeline

jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
CMakeLists.txt
33 ↗(On Diff #13083)

Nit: This comment is looking redundant. Consider removing it.

This revision is now accepted and ready to land.Sep 23 2019, 23:55
Fabien planned changes to this revision.Sep 24 2019, 08:26

Rebase on top of D4144.
Update comment as per feedback.
Do not check bench or test binaries, that are not intended to be installed.

This revision is now accepted and ready to land.Sep 24 2019, 09:51
This revision was automatically updated to reflect the committed changes.