Page MenuHomePhabricator

[CMAKE] Add the check-security target
ClosedPublic

Authored by Fabien on Mon, Sep 23, 13:00.

Details

Summary

This target runs the security-check.py scripts on the executables.
This is the equivalent of the autotools check-security rule.

Depends on D4136.

Test Plan

Build the depends subsystem for linux 64, then:

mkdir buildcmake && cd buildcmake
cmake -GNinja .. \
  -DENABLE_GLIBC_BACK_COMPAT=ON \
  -DENABLE_STATIC_LIBSTDCXX=ON \
  -DENABLE_REDUCE_EXPORTS=ON \
  -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Linux64.cmake
ninja check-security

If should be successful.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Mon, Sep 23, 13:00
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Sep 23, 13:00
jasonbcox accepted this revision.Mon, Sep 23, 23:56
This revision is now accepted and ready to land.Mon, Sep 23, 23:56
Fabien planned changes to this revision.Tue, Sep 24, 08:26
Fabien updated this revision to Diff 13108.Tue, Sep 24, 09:58

Rebase and don't run security checks on target which are not intended to be installed.

This revision is now accepted and ready to land.Tue, Sep 24, 09:58
This revision was automatically updated to reflect the committed changes.