Page MenuHomePhabricator

[CMAKE] Add the check-security target
ClosedPublic

Authored by Fabien on Sep 23 2019, 13:00.

Details

Summary

This target runs the security-check.py scripts on the executables.
This is the equivalent of the autotools check-security rule.

Depends on D4136.

Test Plan

Build the depends subsystem for linux 64, then:

mkdir buildcmake && cd buildcmake
cmake -GNinja .. \
  -DENABLE_GLIBC_BACK_COMPAT=ON \
  -DENABLE_STATIC_LIBSTDCXX=ON \
  -DENABLE_REDUCE_EXPORTS=ON \
  -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Linux64.cmake
ninja check-security

If should be successful.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_check_security
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7553
Build 13146: Bitcoin ABC Buildbot (legacy)
Build 13145: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Sep 23 2019, 23:56
Fabien planned changes to this revision.Sep 24 2019, 08:26

Rebase and don't run security checks on target which are not intended to be installed.

This revision is now accepted and ready to land.Sep 24 2019, 09:58
This revision was automatically updated to reflect the committed changes.