Page MenuHomePhabricator
Differential D4164

Merge #13304: qa: Fix wallet_listreceivedby race
ClosedPublic
Actions

Authored by nakihito on Sep 27 2019, 00:34.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGaf3079ad32ef: Merge #13304: qa: Fix wallet_listreceivedby race
rABCaf3079ad32ef: Merge #13304: qa: Fix wallet_listreceivedby race
Summary

fa865efa4a qa: Fix wallet_listreceivedby race (MarcoFalke)

Pull request description:

Generating a block on node 0 will only get node 0 out of IBD and not node 1. So the inv for the `txid` is dropped by node 1 and the call to `sync_all` fails.

Solve it by a call to `sync_blocks` after `generate`.

Tree-SHA512: e21b01a9e8c90bd6a3aad290c97cc4866ab384e22797b318eed55ae2767512203597d3a184b23ad5a3fe76bdbb8a3d5c51e097d56b160232851164434059ff23

Backport of Core PR13304
https://github.com/bitcoin/bitcoin/pull/13304/

Test Plan
test_runner.py wallet_listreceivedby

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Sep 27 2019, 00:34
Owners added a reviewer: Restricted Owners Package.Sep 27 2019, 00:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 27 2019, 00:34
nakihito planned changes to this revision.Sep 27 2019, 00:34
teamcity added a comment.Sep 27 2019, 00:35

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 27 2019, 00:44

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7602: Diff 13163.Sep 27 2019, 00:44
nakihito requested review of this revision.Sep 27 2019, 00:56
deadalnix accepted this revision.Sep 27 2019, 12:59
This revision is now accepted and ready to land.Sep 27 2019, 12:59
Closed by commit rABCaf3079ad32ef: Merge #13304: qa: Fix wallet_listreceivedby race (authored by MarcoFalke <falke.marco@gmail.com>, committed by nakihito). · Explain WhySep 27 2019, 18:10
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABCaf3079ad32ef: Merge #13304: qa: Fix wallet_listreceivedby race.
Nico Guiton <nico@bitframe.org> added a commit: rSTAGINGaf3079ad32ef: Merge #13304: qa: Fix wallet_listreceivedby race.Sep 27 2019, 22:49

Revision Contents
Changeset List

PathSize
test/
functional/
2 lines

Diff 13185

View Options

test/functional/wallet_listreceivedby.py

Loading...