Page MenuHomePhabricator
Differential D4167

Add support for Glibc version 2.28
ClosedPublic
Actions

Authored by Fabien on Sep 27 2019, 13:13.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING98415c84aa38: Add support for Glibc version 2.28
rABC98415c84aa38: Add support for Glibc version 2.28
Summary

The Glibc backward compatibility feature handles up to version 2.27
(used by Ubuntu Bionic). This diffs adds support for the version 2.28
(used by Debian Buster).

There is an additional compatibility fix involved due to the update of
fcntl() and the introduction of the new fcntl64() function.
These functions are linked against their previous version through a
compatibility symbol.

Test Plan

Cross build for all the linux platforms on an OS that ships Glibc 2.28
(tested on Debian Buster). Use both autotools and cmake for the
build.
Run the symbol-check.py script against the binaries and check there is
no complaint on fcntl or fcntl64 symbol being from a too recent
Glibc.
Check the binaries run on OS with a libc.so.6 version < 2.28

Diff Detail

Repository
rABC Bitcoin ABC
Branch
glibc_2_28_back_compat
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7628
Build 13296: Bitcoin ABC Buildbot (legacy)
Build 13295: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 27 2019, 13:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 27 2019, 13:13
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Sep 27 2019, 13:14

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien added a comment.Sep 27 2019, 13:17

Note to reviewers:

This is WIP while the gitian builds on glibc < 2.28 are running.
The cmake tests have been run locally, the gitian builds over glibc 2.28 are running.

This diff is set up for early review, so if changes are requested it can be handled quickly.

teamcity added a comment.Sep 27 2019, 13:19

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Sep 27 2019, 13:24

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing failed.

Harbormaster completed remote builds in B7606: Diff 13168.Sep 27 2019, 13:24
teamcity added a comment.Sep 27 2019, 13:24

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Fabien planned changes to this revision.Sep 27 2019, 13:35

Build fails with autotools (is_same(off_t, off64_t) returns true on linux32 platform ???).

Fabien updated this revision to Diff 13186.Sep 27 2019, 18:42

Fix autotools detection by moving the check before the CFLAGS enforce LFS.
Fix glibc_compat.cpp comment confusion between LFS and LFN.

teamcity added a comment.Sep 27 2019, 18:42

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 27 2019, 18:43

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Sep 27 2019, 18:51

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7617: Diff 13186.Sep 27 2019, 18:51
teamcity added a comment.Sep 27 2019, 18:52

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

Fabien updated this revision to Diff 13261.Sep 28 2019, 01:58

Revert configure logic to wrap when needed.

teamcity added a comment.Sep 28 2019, 01:58

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 28 2019, 01:59

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Sep 28 2019, 02:07

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7628: Diff 13261.Sep 28 2019, 02:07
teamcity added a comment.Sep 28 2019, 02:14

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

Fabien updated this revision to Diff 13262.Sep 28 2019, 06:45

Rebase on master (was on top of D4095, thus failing the symbol check with gitian on stretch).

teamcity added a comment.Sep 28 2019, 06:46

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 28 2019, 06:46

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

Harbormaster completed remote builds in B7629: Diff 13262.Sep 28 2019, 06:55
teamcity added a comment.Sep 28 2019, 06:55

Build Bitcoin-ABC / Diffs / Diff Testing passed.

teamcity added a comment.Sep 28 2019, 07:05

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

teamcity added a comment.Sep 28 2019, 11:16

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Sep 28 2019, 11:16

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Sep 28 2019, 11:21

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

teamcity added a comment.Sep 28 2019, 11:28

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

deadalnix accepted this revision.Sep 28 2019, 14:53
This revision is now accepted and ready to land.Sep 28 2019, 14:53
Fabien planned changes to this revision.Sep 29 2019, 06:17
Fabien updated this revision to Diff 13268.Sep 30 2019, 10:50

Fix Invalid argument by passing the address of first vararg as a void *.
The same is done internally by the glibc, but the compatibility symbols seems
to complain when the full vararg list is passed.

This revision is now accepted and ready to land.Sep 30 2019, 10:50
teamcity added a comment.Sep 30 2019, 10:51

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 30 2019, 10:53

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

Fabien retitled this revision from [WIP] Add support for Glibc version 2.28 to Add support for Glibc version 2.28.Sep 30 2019, 10:54
teamcity added a comment.Sep 30 2019, 10:57

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B7632: Diff 13268!Sep 30 2019, 10:57
teamcity added a comment.Sep 30 2019, 10:58

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 30 2019, 11:08

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7632: Diff 13268.Sep 30 2019, 11:08
teamcity added a comment.Sep 30 2019, 11:12

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

Fabien added a child revision: D4182: [CMAKE] Enable Large File Support on platforms that don't enable it by default.Sep 30 2019, 16:37
Fabien added a child revision: D4185: Migrate Gitian container to Debian 10 Buster.Oct 1 2019, 10:40
Closed by commit rABC98415c84aa38: Add support for Glibc version 2.28 (authored by Fabien). · Explain WhyOct 1 2019, 13:52
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC98415c84aa38: Add support for Glibc version 2.28.
Fabien added a commit: rSTAGING98415c84aa38: Add support for Glibc version 2.28.Oct 9 2019, 20:10

Revision Contents
Changeset List

PathSize
14 lines
src/
4 lines
compat/
46 lines
config/
9 lines
1 line

Diff 13261

View Options

configure.ac

Loading...
View Options

src/CMakeLists.txt

Loading...
View Options

src/compat/glibc_compat.cpp

Loading...
View Options

src/config/CMakeLists.txt

Loading...
View Options

src/config/bitcoin-config.h.cmake.in

Loading...