Page MenuHomePhabricator
Differential D4170

Add AssertLockHeld assertions in CWallet::ListCoins
ClosedPublic
Actions

Authored by deadalnix on Sep 27 2019, 16:14.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGb660a2d9f5a2: Add AssertLockHeld assertions in CWallet::ListCoins
rABCb660a2d9f5a2: Add AssertLockHeld assertions in CWallet::ListCoins
Summary
  • Add AssertLockHeld assertions in CWallet::ListCoins
  • Add EXCLUSIVE_LOCKS_REQUIRED to CWallet::ListCoins

Suggested by MarcoFalke <falke.marco@gmail.com> in
https://github.com/bitcoin/bitcoin/pull/10605#issuecomment-417643535

This is a backport of Core PR10605

Test Plan
  • Build with clang and make sure there are no warning related to locks.
  • Build in debug mode and run the extended test suite.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr10605
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7612
Build 13264: Bitcoin ABC Buildbot (legacy)
Build 13263: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 27 2019, 16:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 27 2019, 16:14
teamcity added a comment.Sep 27 2019, 16:15

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 27 2019, 16:26

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7611: Diff 13178.Sep 27 2019, 16:26
deadalnix abandoned this revision.Sep 27 2019, 16:55
deadalnix reclaimed this revision.
deadalnix updated this revision to Diff 13179.Sep 27 2019, 16:58

Full PR

teamcity added a comment.Sep 27 2019, 16:58

Build Bitcoin-ABC / Diffs / Diff Testing started.

deadalnix retitled this revision from Add EXCLUSIVE_LOCKS_REQUIRED to CWallet::ListCoins to Add AssertLockHeld assertions in CWallet::ListCoins.Sep 27 2019, 16:59
deadalnix edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B7612: Diff 13179.Sep 27 2019, 17:08
teamcity added a comment.Sep 27 2019, 17:08

Build Bitcoin-ABC / Diffs / Diff Testing passed.

jasonbcox accepted this revision.Sep 27 2019, 21:59
This revision is now accepted and ready to land.Sep 27 2019, 21:59
Closed by commit rABCb660a2d9f5a2: Add AssertLockHeld assertions in CWallet::ListCoins (authored by Russell Yanofsky <russ@yanofsky.org>, committed by deadalnix). · Explain WhySep 28 2019, 12:41
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCb660a2d9f5a2: Add AssertLockHeld assertions in CWallet::ListCoins.
deadalnix added a commit: rSTAGINGb660a2d9f5a2: Add AssertLockHeld assertions in CWallet::ListCoins.Oct 9 2019, 20:09

Revision Contents
Changeset List

PathSize
src/
wallet/
test/
16 lines
3 lines
12 lines

Diff 13179

View Options

src/wallet/test/wallet_tests.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...