Page MenuHomePhabricator

[CMAKE] Enable Large File Support on platforms that don't enable it by default
ClosedPublic

Authored by Fabien on Sep 30 2019, 16:37.

Details

Summary

This targets all 32-bit platforms and windows.

The test for off_t == off64_t from D4167 is updated to accommodate OSX
not providing the off64_t type and renamed to be more meaningful as a
check for LFS.

The -D_FILE_OFFSET_BITS=64 is added to enable LFS, which is the
correct flag for all our currently supported platforms. Other flags can
be added later for other platforms as needed. Note that mingw also
requires a linker flag for win32.

Depends on D4167.

Test Plan

Build with cmake on all 32 bits platforms + windows.
Run the gitian builds (sanity check).
Check the binaries run in all cases.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien retitled this revision from Enable Large File Support on platforms that don't enable it by default to [CMAKE] Enable Large File Support on platforms that don't enable it by default.Sep 30 2019, 16:38
This revision is now accepted and ready to land.Oct 1 2019, 11:27