Paths

Table of Contentst

Change CI builds to use utf-8 encoding
ClosedPublic
Actions

Authored by jasonbcox on Sep 30 2019, 23:06.

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING4a4b489b0d84: Change CI builds to use utf-8 encoding
rABC4a4b489b0d84: Change CI builds to use utf-8 encoding

Summary

With the codeset unset, the builds are not guaranteed to use UTF-8, so now we set it explicitly.

This fixes the build issue discovered in D4174.

Depends on D4183

Test Plan

ABC_BUILD_NAME=build-default ./build-configurations.sh

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cienc

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7639
Build 13318: Bitcoin ABC Buildbot (legacy)
Build 13317: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Sep 30 2019, 23:06

Herald added a reviewer: deadalnix. · View Herald TranscriptSep 30 2019, 23:06

Build Bitcoin-ABC / Diffs / Diff Testing started.

jasonbcox edited the summary of this revision. (Show Details)Sep 30 2019, 23:06

jasonbcox added a parent revision: D4183: Added support for `export LC_ALL=C.UTF-8` to the shell linter.

Harbormaster completed remote builds in B7639: Diff 13280.Sep 30 2019, 23:20

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Fabien accepted this revision.Oct 1 2019, 06:09

This revision is now accepted and ready to land.Oct 1 2019, 06:09

Closed by commit rABC4a4b489b0d84: Change CI builds to use utf-8 encoding (authored by jasonbcox). · Explain WhyOct 1 2019, 18:56

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABC4a4b489b0d84: Change CI builds to use utf-8 encoding.

jasonbcox added a commit: rSTAGING4a4b489b0d84: Change CI builds to use utf-8 encoding.Oct 9 2019, 20:10

Revision Contents
Changeset List

Path

Size

contrib/

teamcity/

build-configurations.sh

2 lines

Diff 13280

View Options

contrib/teamcity/build-configurations.sh

Change CI builds to use utf-8 encodingClosedPublicActions