Page MenuHomePhabricator

[CMAKE] Rename bitcoinconsensus target to avoid collision
AbandonedPublic

Authored by Fabien on Oct 2 2019, 10:04.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

The actual bitcoinconsensus target is used for internal linking, and
the name is going to conflict when building the libbitcoinconsensus
shared library which is delivered as part of the release.

This diff renames the target to bitcoin_consensus which is the same
name than autotools, because I couldn't find a better suited name.

There is no functional change.

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_rename_bitcoin_consensus
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7663
Build 13365: Bitcoin ABC Buildbot (legacy)
Build 13364: arc lint + arc unit

Event Timeline

deadalnix requested changes to this revision.Oct 2 2019, 12:15

There is no name collision, because this is what it is.

This revision now requires changes to proceed.Oct 2 2019, 12:15