Page MenuHomePhabricator

[CMAKE] Rename bitcoinconsensus target to avoid collision
Needs RevisionPublic

Authored by Fabien on Wed, Oct 2, 10:04.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

The actual bitcoinconsensus target is used for internal linking, and
the name is going to conflict when building the libbitcoinconsensus
shared library which is delivered as part of the release.

This diff renames the target to bitcoin_consensus which is the same
name than autotools, because I couldn't find a better suited name.

There is no functional change.

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_rename_bitcoin_consensus
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7663
Build 13365: Bitcoin ABC Teamcity Staging
Build 13364: arc lint + arc unit

Event Timeline

Fabien created this revision.Wed, Oct 2, 10:04
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Oct 2, 10:04
deadalnix requested changes to this revision.Wed, Oct 2, 12:15

There is no name collision, because this is what it is.

This revision now requires changes to proceed.Wed, Oct 2, 12:15