Page MenuHomePhabricator
Differential D4227

mempool, validation: Explain cs_main locking semantics
ClosedPublic
Actions

Authored by fpelliccioni on Oct 8 2019, 19:09.

Details

Reviewers
Fabien
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING8408a0cdcf41: mempool, validation: Explain cs_main locking semantics
rABC8408a0cdcf41: mempool, validation: Explain cs_main locking semantics
Summary

Both the chain state and the transaction pool are validation specific, but access to them is protected by two locks. The two locks have the following semantics:

Backport of Bitcoin Core PR14963
https://github.com/bitcoin/bitcoin/pull/14963

Test Plan
  1. Build with Clang in Debug mode:
CXX=clang++ CC=clang cmake .. -GNinja -DCMAKE_BUILD_TYPE=Debug
ninja check-all
  1. Verify that the compiler has not emitted a thread-safety warning.
  2. Run the node: ./src/bitcoind -regtest
  3. Verify that text similar to "Assertion failed: lock ... not held ..." is not printed on stderr.
  1. Run benchmarks:
cmake .. -GNinja
ninja bench-bitcoin
./src/bench/bitcoin-bench

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

fpelliccioni created this revision.Oct 8 2019, 19:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 8 2019, 19:09
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Oct 8 2019, 19:09

Build Bitcoin-ABC / Diffs / Diff Testing started.

fpelliccioni edited the test plan for this revision. (Show Details)Oct 8 2019, 19:10
fpelliccioni planned changes to this revision.Oct 8 2019, 19:12

I don't know what happened with Squash... I lost some of the changes...

teamcity added a comment.Oct 8 2019, 19:25

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7719: Diff 13408.Oct 8 2019, 19:25
fpelliccioni updated this revision to Diff 13415.Oct 9 2019, 12:37
fpelliccioni edited the test plan for this revision. (Show Details)

fix squashing

teamcity added a comment.Oct 9 2019, 12:38

Build Bitcoin-ABC / Diffs / Diff Testing started.

deadalnix accepted this revision.Oct 9 2019, 12:44
This revision is now accepted and ready to land.Oct 9 2019, 12:44
teamcity added a comment.Oct 9 2019, 12:53

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7724: Diff 13415.Oct 9 2019, 12:53
Closed by commit rABC8408a0cdcf41: mempool, validation: Explain cs_main locking semantics (authored by MarcoFalke <falke.marco@gmail.com>, committed by fpelliccioni). · Explain WhyOct 9 2019, 17:21
This revision was automatically updated to reflect the committed changes.
fpelliccioni added a commit: rABC8408a0cdcf41: mempool, validation: Explain cs_main locking semantics.
fpelliccioni added a commit: rSTAGING8408a0cdcf41: mempool, validation: Explain cs_main locking semantics.Oct 9 2019, 20:12

Revision Contents
Changeset List

Diff 13417

View Options

src/bench/mempool_eviction.cpp

Loading...
View Options

src/sync.h

Loading...
View Options

src/test/blockencodings_tests.cpp

Loading...
View Options

src/test/mempool_tests.cpp

Loading...
View Options

src/test/miner_tests.cpp

Loading...
View Options

src/test/policyestimator_tests.cpp

Loading...
View Options

src/txmempool.h

Loading...
View Options

src/validation.cpp

Loading...