Page MenuHomePhabricator
Differential D4228

Do not cache version in cmake build
ClosedPublic
Actions

Authored by deadalnix on Oct 9 2019, 00:05.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGaaf5c6a6a702: Do not cache version in cmake build
rABCaaf5c6a6a702: Do not cache version in cmake build
Summary

The cmake build produce stale version numbers as a result of the caching.

Test Plan

Build with cmake.

Increment the version number of bitcoin-abc in /CMakeLists.txt .

Rebuild, make sure the version actually changed in the generated version.h

Diff Detail

Repository
rABC Bitcoin ABC
Branch
versionnocache
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7723
Build 13485: Bitcoin ABC Buildbot (legacy)
Build 13484: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 9 2019, 00:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 9 2019, 00:05
teamcity added a comment.Oct 9 2019, 00:05

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Oct 9 2019, 00:16

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7720: Diff 13411.Oct 9 2019, 00:16
Fabien requested changes to this revision.Oct 9 2019, 06:27
Fabien added a subscriber: Fabien.

It's breaking the doc/Doxyfile.cmake.in template.
Please replace the line:
PROJECT_NUMBER = ${CLIENT_VERSION_MAJOR}.${CLIENT_VERSION_MINOR}.${CLIENT_VERSION_REVISION}
with:
PROJECT_NUMBER = ${bitcoin-abc_VERSION}
to fix it.

This revision now requires changes to proceed.Oct 9 2019, 06:27
deadalnix updated this revision to Diff 13414.Oct 9 2019, 12:28

Fix doc

teamcity added a comment.Oct 9 2019, 12:28

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7723: Diff 13414.Oct 9 2019, 12:38
teamcity added a comment.Oct 9 2019, 12:38

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Fabien accepted this revision.Oct 9 2019, 12:43
This revision is now accepted and ready to land.Oct 9 2019, 12:43
Closed by commit rABCaaf5c6a6a702: Do not cache version in cmake build (authored by deadalnix). · Explain WhyOct 10 2019, 12:54
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCaaf5c6a6a702: Do not cache version in cmake build.
deadalnix added a commit: rSTAGINGaaf5c6a6a702: Do not cache version in cmake build.Apr 7 2020, 21:25

Revision Contents
Changeset List

PathSize
doc/
2 lines
src/
config/
6 lines

Diff 13414

View Options

doc/Doxyfile.cmake.in

Loading...
View Options

src/config/CMakeLists.txt

Loading...