Page MenuHomePhabricator
Differential D4231

[gitian-build] Refactor to calculate output directories in fewer places
ClosedPublic
Actions

Authored by jasonbcox on Oct 10 2019, 02:40.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGba1767e8c10f: [gitian-build] Refactor to calculate output directories in fewer places
rABCba1767e8c10f: [gitian-build] Refactor to calculate output directories in fewer places
Summary

This makes changes less error prone.

Test Plan
./gitian-build.py -n -c -b gitianuser v0.20.3

Verify gitian build binaries still output as expected.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Oct 10 2019, 02:40
Herald added a reviewer: deadalnix. · View Herald TranscriptOct 10 2019, 02:40
teamcity added a comment.Oct 10 2019, 02:40

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Oct 10 2019, 02:41

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

jasonbcox edited the test plan for this revision. (Show Details)Oct 10 2019, 02:44
jasonbcox added a child revision: D4232: [gitian-build] Move manifest files to output directory.
jasonbcox edited the test plan for this revision. (Show Details)
teamcity added a comment.Oct 10 2019, 02:51

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7733: Diff 13482.Oct 10 2019, 02:51
teamcity added a comment.Oct 10 2019, 03:00

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

jasonbcox planned changes to this revision.Oct 10 2019, 13:56
jasonbcox requested review of this revision.Oct 10 2019, 16:05
Fabien accepted this revision.Oct 11 2019, 08:13
This revision is now accepted and ready to land.Oct 11 2019, 08:13
Closed by commit rABCba1767e8c10f: [gitian-build] Refactor to calculate output directories in fewer places (authored by jasonbcox). · Explain WhyOct 11 2019, 16:12
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABCba1767e8c10f: [gitian-build] Refactor to calculate output directories in fewer places.
jasonbcox added a commit: rSTAGINGba1767e8c10f: [gitian-build] Refactor to calculate output directories in fewer places.Apr 7 2020, 21:25

Revision Contents
Changeset List

PathSize
contrib/
22 lines

Diff 13504

View Options

contrib/gitian-build.py

Loading...