Page MenuHomePhabricator

Methods for interacting with PSBT structs
ClosedPublic

Authored by deadalnix on Wed, Oct 23, 16:55.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABCddf9cd8d0e84: Methods for interacting with PSBT structs
Summary

Added methods which move data to/from SignatureData objects to
PSBTInput and PSBTOutput objects.

Added sanity checks for PSBTs as a whole which are done immediately
after deserialization.

Added Merge methods to merge a PSBT into another one.

This is a partial backport of Core PR13557 : https://github.com/bitcoin/bitcoin/pull/13557/commits/e9d86a43ad8b1ab83b324e9a7a64c43a61337501

Depends on D4285

Test Plan

Unfortunately, The PR dump all the tests at once at the end, so there are no tests for the new code.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Wed, Oct 23, 16:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Oct 23, 16:55
jasonbcox edited the summary of this revision. (Show Details)Wed, Oct 23, 22:29
jasonbcox accepted this revision.Wed, Oct 23, 22:41
This revision is now accepted and ready to land.Wed, Oct 23, 22:41
This revision was automatically updated to reflect the committed changes.