Page MenuHomePhabricator

SignPSBTInput wrapper function

Authored by deadalnix on Oct 23 2019, 17:53.



The SignPSBTInput function takes a PSBTInput, SignatureData, SigningProvider,
and other data necessary for signing. It fills the SignatureData with data from
the PSBTInput, retrieves the UTXO from the PSBTInput, signs and finalizes the
input if possible, and then extracts the results from the SignatureData and
puts them back into the PSBTInput.

This is a partial backport of Core PR13557 :

Depends on D4286

Test Plan
Unfortunately, The PR dump all the tests at once at the end, so there are no tests for the new code.

Diff Detail

rABC Bitcoin ABC
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Oct 23 2019, 17:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 23 2019, 17:53
jasonbcox accepted this revision.Oct 24 2019, 00:02
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
223 ↗(On Diff #13670)

nit: remove or scriptwitness

This revision is now accepted and ready to land.Oct 24 2019, 00:02
This revision was automatically updated to reflect the committed changes.