Page MenuHomePhabricator

SignPSBTInput wrapper function
ClosedPublic

Authored by deadalnix on Wed, Oct 23, 17:53.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC91b535a574ca: SignPSBTInput wrapper function
Summary

The SignPSBTInput function takes a PSBTInput, SignatureData, SigningProvider,
and other data necessary for signing. It fills the SignatureData with data from
the PSBTInput, retrieves the UTXO from the PSBTInput, signs and finalizes the
input if possible, and then extracts the results from the SignatureData and
puts them back into the PSBTInput.

This is a partial backport of Core PR13557 : https://github.com/bitcoin/bitcoin/pull/13557/commits/8b5ef2793748065727a9a2498805ae5b269dcb4f

Depends on D4286

Test Plan
Unfortunately, The PR dump all the tests at once at the end, so there are no tests for the new code.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Wed, Oct 23, 17:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Oct 23, 17:53
jasonbcox accepted this revision.Thu, Oct 24, 00:02
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/script/sign.cpp
223 ↗(On Diff #13670)

nit: remove or scriptwitness

This revision is now accepted and ready to land.Thu, Oct 24, 00:02
This revision was automatically updated to reflect the committed changes.