HomePhabricator

SignPSBTInput wrapper function

Authored by Andrew Chow <achow101-github@achow101.com> on Jun 29 2018, 01:56.

Description

SignPSBTInput wrapper function

Summary:
The SignPSBTInput function takes a PSBTInput, SignatureData, SigningProvider,
and other data necessary for signing. It fills the SignatureData with data from
the PSBTInput, retrieves the UTXO from the PSBTInput, signs and finalizes the
input if possible, and then extracts the results from the SignatureData and
puts them back into the PSBTInput.

This is a partial backport of Core PR13557 : https://github.com/bitcoin/bitcoin/pull/13557/commits/8b5ef2793748065727a9a2498805ae5b269dcb4f

Depends on D4286

Test Plan:

Unfortunately, The PR dump all the tests at once at the end, so there are no tests for the new code.

Reviewers: #bitcoin_abc, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Subscribers: jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D4289

Details

Committed
deadalnixWed, Oct 30, 17:37
Pushed
deadalnixWed, Oct 30, 17:37
Reviewer
Restricted Project
Differential Revision
D4289: SignPSBTInput wrapper function
Parents
rABCddf9cd8d0e84: Methods for interacting with PSBT structs
Branches
Unknown
Tags
Unknown

Event Timeline

deadalnix committed rABC91b535a574ca: SignPSBTInput wrapper function (authored by Andrew Chow <achow101-github@achow101.com>).Wed, Oct 30, 17:37