Update qt/qvaluecombobox.cpp to use Qt5 connect syntax
ClosedPublic
Actions

Authored by nakihito on Oct 30 2019, 21:41.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING69252005c675: Update qt/qvaluecombobox.cpp to use Qt5 connect syntax
rABC69252005c675: Update qt/qvaluecombobox.cpp to use Qt5 connect syntax

Summary

Updates to use Qt5 connect syntax over Qt4.
See https://wiki.qt.io/New_Signal_Slot_Syntax for details.

Partial backport of Core PR13529
https://github.com/bitcoin/bitcoin/pull/13529/commits/f78558f1e39198779bdb17e2b0e256fb99ad4b28?file-filters%5B%5D=.cpp#diff-50388e8625cebcce224abde550638dfc

Test Plan

make check
./bitcoin-qt
Send

Increment and decrement the amount value and manually input a value into the amount box.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito created this revision.Oct 30 2019, 21:41

Owners added a reviewer: Restricted Owners Package.Oct 30 2019, 21:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 30 2019, 21:41

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7916: Diff 13795.Oct 30 2019, 21:57

Build Bitcoin-ABC / Diffs / Diff Testing passed.

jasonbcox accepted this revision.Oct 30 2019, 23:54

This revision is now accepted and ready to land.Oct 30 2019, 23:54

Closed by commit rABC69252005c675: Update qt/qvaluecombobox.cpp to use Qt5 connect syntax (authored by nakihito). · Explain WhyOct 30 2019, 23:58

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABC69252005c675: Update qt/qvaluecombobox.cpp to use Qt5 connect syntax.

nakihito added a commit: rSTAGING69252005c675: Update qt/qvaluecombobox.cpp to use Qt5 connect syntax.Apr 7 2020, 21:33

Revision Contents
Changeset List

Path

Size

src/

qt/

qvaluecombobox.cpp

6 lines

Diff 13819

View Options

Update qt/qvaluecombobox.cpp to use Qt5 connect syntaxClosedPublicActions