Page MenuHomePhabricator
Differential D4324

Update qt/recentrequestdialog.cpp with Qt5 connect syntax
ClosedPublic
Actions

Authored by nakihito on Oct 30 2019, 22:08.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING9060a1d42bda: Update qt/recentrequestdialog.cpp with Qt5 connect syntax
rABC9060a1d42bda: Update qt/recentrequestdialog.cpp with Qt5 connect syntax
Summary

Updates to use Qt5 connect syntax over Qt4.
See https://wiki.qt.io/New_Signal_Slot_Syntax for details.

Partial backport of Core PR13529
https://github.com/bitcoin/bitcoin/pull/13529/commits/f78558f1e39198779bdb17e2b0e256fb99ad4b28?file-filters%5B%5D=.cpp#diff-69b85bc42435f7f07306f5b22e730e0d

Test Plan
make check
./bitcoin-qt

Open the Receive menu.

pr13529-RecentRequestsTableModel.png (539×848 px, 32 KB)

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Oct 30 2019, 22:08
Owners added a reviewer: Restricted Owners Package.Oct 30 2019, 22:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 30 2019, 22:08
nakihito planned changes to this revision.Oct 30 2019, 22:08
teamcity added a comment.Oct 30 2019, 22:08

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito requested review of this revision.Oct 30 2019, 22:09
nakihito edited the test plan for this revision. (Show Details)
teamcity added a comment.Oct 30 2019, 22:18

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7920: Diff 13803.Oct 30 2019, 22:18
deadalnix accepted this revision.Oct 31 2019, 12:34
This revision is now accepted and ready to land.Oct 31 2019, 12:34
Closed by commit rABC9060a1d42bda: Update qt/recentrequestdialog.cpp with Qt5 connect syntax (authored by nakihito). · Explain WhyOct 31 2019, 17:14
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABC9060a1d42bda: Update qt/recentrequestdialog.cpp with Qt5 connect syntax.
nakihito added a commit: rSTAGING9060a1d42bda: Update qt/recentrequestdialog.cpp with Qt5 connect syntax.Apr 7 2020, 21:33

Revision Contents
Changeset List

PathSize
src/
qt/
4 lines

Diff 13828

View Options

src/qt/recentrequeststablemodel.cpp

Loading...