Page MenuHomePhabricator

build: Require python 3.5
ClosedPublic

Authored by Fabien on Mon, Nov 4, 22:17.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rABCe4fdc45af037: build: Require python 3.5
Summary

Partial backport of core PR14954 (commit fab5a1e):
https://github.com/bitcoin/bitcoin/pull/14954/commits/fab5a1e0f492f920270c661954802749dfac5fa1

Note: the depends README change is not backported because it has
dependencies that will be added later.

Test Plan
./test/functional/test_runner.py --extended

Run the gitian builds.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Mon, Nov 4, 22:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Nov 4, 22:17
jasonbcox accepted this revision.Tue, Nov 5, 01:16
jasonbcox added a subscriber: jasonbcox.

Reviewer note: The code changed in test_framework/script.py does not appear in our codebase. We'll need to keep an eye out for slow backports that might introduce it.

configure.ac
87 ↗(On Diff #13907)

Are these in order of preference? I noticed our order is reversed from Core.

This revision is now accepted and ready to land.Tue, Nov 5, 01:16
This revision was automatically updated to reflect the committed changes.
Fabien added inline comments.Tue, Nov 5, 07:22
configure.ac
87 ↗(On Diff #13907)

Yes it is, see https://github.com/bitcoin/bitcoin/pull/15285.
The rational doesn't apply to us as we are not using pyenv.