Page MenuHomePhabricator
Differential D4372

build: Require python 3.5
ClosedPublic
Actions

Authored by Fabien on Nov 4 2019, 22:17.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGe4fdc45af037: build: Require python 3.5
rABCe4fdc45af037: build: Require python 3.5
Summary

Partial backport of core PR14954 (commit fab5a1e):
https://github.com/bitcoin/bitcoin/pull/14954/commits/fab5a1e0f492f920270c661954802749dfac5fa1

Note: the depends README change is not backported because it has
dependencies that will be added later.

Test Plan
./test/functional/test_runner.py --extended

Run the gitian builds.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 4 2019, 22:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 4 2019, 22:17
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Nov 4 2019, 22:17

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien added a child revision: D4373: test: Remove python3.4 workaround in feature_dbcrash.Nov 4 2019, 22:18
Harbormaster completed remote builds in B7978: Diff 13907.Nov 4 2019, 22:28
teamcity added a comment.Nov 4 2019, 22:28

Build Bitcoin-ABC / Diffs / Diff Testing passed.

teamcity added a comment.Nov 4 2019, 22:49

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Nov 4 2019, 22:50

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Nov 4 2019, 22:53

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

teamcity added a comment.Nov 4 2019, 22:53

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Nov 4 2019, 23:06

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

teamcity added a comment.Nov 4 2019, 23:10

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

jasonbcox accepted this revision.Nov 5 2019, 01:16
jasonbcox added a subscriber: jasonbcox.

Reviewer note: The code changed in test_framework/script.py does not appear in our codebase. We'll need to keep an eye out for slow backports that might introduce it.

configure.ac
87 ↗(On Diff #13907)

Are these in order of preference? I noticed our order is reversed from Core.

This revision is now accepted and ready to land.Nov 5 2019, 01:16
Closed by commit rABCe4fdc45af037: build: Require python 3.5 (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyNov 5 2019, 07:14
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCe4fdc45af037: build: Require python 3.5.
Fabien added inline comments.Nov 5 2019, 07:22
configure.ac
87 ↗(On Diff #13907)

Yes it is, see https://github.com/bitcoin/bitcoin/pull/15285.
The rational doesn't apply to us as we are not using pyenv.

jasonbcox mentioned this in D4408: Added a release note regarding builds needing python 3.5.Nov 7 2019, 22:22
jasonbcox mentioned this in rABC947c1bc5e02b: Added a release note regarding builds needing python 3.5.Nov 8 2019, 17:06
Fabien added a commit: rSTAGINGe4fdc45af037: build: Require python 3.5.Apr 7 2020, 21:36
jasonbcox mentioned this in rSTAGING947c1bc5e02b: Added a release note regarding builds needing python 3.5.Apr 7 2020, 21:38

Revision Contents
Changeset List

PathSize
2 lines
4 lines
contrib/
devtools/
2 lines
2 lines
gitian-descriptors/
2 lines
6 lines
2 lines
linearize/
3 lines
doc/
2 lines
test/
functional/
test_framework/
5 lines
5 lines
4 lines

Diff 13915

View Options

CMakeLists.txt

Loading...
View Options

configure.ac

Loading...
View Options

contrib/devtools/README.md

Loading...
View Options

contrib/devtools/symbol-check.py

Loading...
View Options

contrib/gitian-descriptors/gitian-linux.yml

Loading...
View Options

contrib/gitian-descriptors/gitian-osx.yml

Loading...
View Options

contrib/gitian-descriptors/gitian-win.yml

Loading...
View Options

contrib/linearize/README.md

Loading...
View Options

doc/dependencies.md

Loading...
View Options

test/functional/test_framework/mininode.py

Loading...
View Options

test/functional/test_framework/test_node.py

Loading...
View Options

test/functional/test_framework/util.py

Loading...