Page MenuHomePhabricator
Differential D438

Get rid of using namespace std in src/rpc
ClosedPublic
Actions

Authored by freetrader on Aug 6 2017, 20:54.

Details

Reviewers
deadalnix
CCulianu
Group Reviewers
Restricted Project
Commits
rSTAGINGd5318085d0da: Get rid of using namespace std in src/rpc
rABCd5318085d0da: Get rid of using namespace std in src/rpc
Summary

as described
take no prisoners

Test Plan

make check
../qa/pull-tester/rpc-tests.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
use_std_in_rpc
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 685
Build 685: arc lint + arc unit

Event Timeline

freetrader created this revision.Aug 6 2017, 20:54
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptAug 6 2017, 20:54
deadalnix accepted this revision.Aug 7 2017, 01:11
This revision is now accepted and ready to land.Aug 7 2017, 01:11
CCulianu accepted this revision.Aug 7 2017, 05:35
CCulianu added a subscriber: CCulianu.

Looks good to me. Just as an aside: I'm all for getting rid of the namespace import -- it's considered bad form to import it in larger programs anyway.

Applied, compiled, tested, works.

Closed by commit rABCd5318085d0da: Get rid of using namespace std in src/rpc (authored by freetrader, committed by freetrader). · Explain WhyAug 7 2017, 07:06
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
rpc/
4 lines
66 lines
62 lines
10 lines
63 lines

Diff 1089

View Options

src/rpc/client.cpp

Loading...
View Options

src/rpc/misc.cpp

Loading...
View Options

src/rpc/net.cpp

Loading...
View Options

src/rpc/protocol.cpp

Loading...
View Options

src/rpc/server.cpp

Loading...