Page MenuHomePhabricator

Modify CSeederNode to allow more testing
Needs RevisionPublic

Authored by nakihito on Sat, Nov 9, 01:14.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

Loosen the API a little bit to allow for testing without completely
destroying encapsulation.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
FormatBitcoincpph
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8042
Build 14079: Bitcoin ABC Buildbot
Build 14078: arc lint + arc unit

Event Timeline

nakihito created this revision.Sat, Nov 9, 01:14
Owners added a reviewer: Restricted Owners Package.Sat, Nov 9, 01:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptSat, Nov 9, 01:14

You can include this with the test. It's not really possible to figure out if that is a good idea or not without having an idea of where this is going.

Fabien requested changes to this revision.Tue, Nov 12, 07:31

Agreed with @deadalnix, clearing my queue.

This revision now requires changes to proceed.Tue, Nov 12, 07:31