Page MenuHomePhabricator

Output descriptors module
ClosedPublic

Authored by deadalnix on Nov 9 2019, 22:43.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
descriptor
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8060
Build 14115: Bitcoin ABC Buildbot (legacy)
Build 14114: arc lint + arc unit

Event Timeline

Fabien requested changes to this revision.Nov 11 2019, 13:12
Fabien added a subscriber: Fabien.

LGTM excepted a few nits

src/script/descriptor.cpp
526 ↗(On Diff #14033)

uint32_t(hardened)

533 ↗(On Diff #14033)

Why did you keep it as constant rather than removing it ?

src/script/descriptor.h
31 ↗(On Diff #14033)

Nit: it looks like clang-format mess the layout when the line is too long with the leading dash.

48 ↗(On Diff #14033)

I don't think we support bech32

src/test/descriptor_tests.cpp
12 ↗(On Diff #14033)

Nit: move libraries in their own section (also boost and string above).

This revision now requires changes to proceed.Nov 11 2019, 13:12
src/script/descriptor.cpp
533 ↗(On Diff #14033)

You are right, I did so to get on with the backport but forgot to clean it up.

src/script/descriptor.h
31 ↗(On Diff #14033)

It's okay, this is removed soon anyways to be moved in the documentation.

This revision is now accepted and ready to land.Nov 12 2019, 07:05
This revision was automatically updated to reflect the committed changes.