This is a partial backport of Core PR13697 : https://github.com/bitcoin/bitcoin/pull/13697/commits/fe8a7dcd78cfeedc9a7c705e91384f793822912b
Also includes:
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rSTAGINGa3f767ce220d: Output descriptors module
rABCa3f767ce220d: Output descriptors module
make check
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- descriptor
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 8060 Build 14115: Bitcoin ABC Buildbot (legacy) Build 14114: arc lint + arc unit
Event Timeline
Comment Actions
LGTM excepted a few nits
| src/script/descriptor.cpp | ||
|---|---|---|
| 526 ↗ | (On Diff #14033) | uint32_t(hardened) |
| 533 ↗ | (On Diff #14033) | Why did you keep it as constant rather than removing it ? |
| src/script/descriptor.h | ||
| 31 ↗ | (On Diff #14033) | Nit: it looks like clang-format mess the layout when the line is too long with the leading dash. |
| 48 ↗ | (On Diff #14033) | I don't think we support bech32 |
| src/test/descriptor_tests.cpp | ||
| 12 ↗ | (On Diff #14033) | Nit: move libraries in their own section (also boost and string above). |
| src/script/descriptor.cpp | ||
|---|---|---|
| 533 ↗ | (On Diff #14033) | You are right, I did so to get on with the backport but forgot to clean it up. |
| src/script/descriptor.h | ||
|---|---|---|
| 31 ↗ | (On Diff #14033) | It's okay, this is removed soon anyways to be moved in the documentation. |