Page MenuHomePhabricator
Differential D4422

Add descriptor reference documentation
ClosedPublic
Actions

Authored by deadalnix on Nov 9 2019, 22:59.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGee04f3cbc3e5: Add descriptor reference documentation
rABCee04f3cbc3e5: Add descriptor reference documentation
Summary
  • Adjust TODO link
  • Replace duplcate reference with reference to reference doc

In addition, add release notes.

Depends on D4421

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr14096
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8051
Build 14097: Bitcoin ABC Buildbot (legacy)
Build 14096: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 9 2019, 22:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 9 2019, 22:59
teamcity added a comment.Nov 9 2019, 22:59

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 9 2019, 23:16

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8051: Diff 14035.Nov 9 2019, 23:16
deadalnix updated this revision to Diff 14052.Nov 11 2019, 14:54

rebase and fix merge conflict

teamcity added a comment.Nov 11 2019, 14:54

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien requested changes to this revision.Nov 11 2019, 14:54
Fabien added a subscriber: Fabien.
Fabien added inline comments.
doc/descriptors.md
1

s/Core/ABC/

3

v0.20.7

46

Needs update

57

Remove

64

Needs update

66

Dito

69

Dito

71

Dito

72

Dito

111

s/Core/ABC/

113

Needs update

This revision now requires changes to proceed.Nov 11 2019, 14:54
Harbormaster completed remote builds in B8061: Diff 14052.Nov 11 2019, 15:03
teamcity added a comment.Nov 11 2019, 15:03

Build Bitcoin-ABC / Diffs / Diff Testing passed.

deadalnix updated this revision to Diff 14072.Nov 12 2019, 13:43

Fix doc and rebase

teamcity added a comment.Nov 12 2019, 13:44

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 12 2019, 13:56

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8074: Diff 14072.Nov 12 2019, 13:56
Fabien requested changes to this revision.Nov 12 2019, 14:01
Fabien added inline comments.
doc/descriptors.md
1 ↗(On Diff #14072)

Core => ABC

3 ↗(On Diff #14072)

Dito

This revision now requires changes to proceed.Nov 12 2019, 14:01
deadalnix added inline comments.Nov 12 2019, 14:34
doc/descriptors.md
3 ↗(On Diff #14072)

Damn, it's really hard to catch them all (pokemon !).

deadalnix updated this revision to Diff 14074.Nov 12 2019, 14:38

Rebase and address comments

teamcity added a comment.Nov 12 2019, 14:38

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B8075: Diff 14074.Nov 12 2019, 14:48
teamcity added a comment.Nov 12 2019, 14:48

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Fabien accepted this revision.Nov 12 2019, 14:52

You finally got the masterball !

This revision is now accepted and ready to land.Nov 12 2019, 14:52
Closed by commit rABCee04f3cbc3e5: Add descriptor reference documentation (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by deadalnix). · Explain WhyNov 12 2019, 15:42
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCee04f3cbc3e5: Add descriptor reference documentation.
deadalnix added a commit: rSTAGINGee04f3cbc3e5: Add descriptor reference documentation.Apr 7 2020, 21:41

Revision Contents
Changeset List

PathSize
doc/
114 lines
6 lines
src/
rpc/
2 lines
script/
53 lines

Diff 14035

View Options

doc/descriptors.md

Loading...
View Options

doc/release-notes.md

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/script/descriptor.h

Loading...